Skip to content

Bump MSRV to v1.83 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinlewi merged 2 commits into from
Apr 15, 2025
Merged

Bump MSRV to v1.83 #140

kevinlewi merged 2 commits into from
Apr 15, 2025

Conversation

@daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Apr 15, 2025

  • Update MSRV to v1.83. Now a lot of our trait constraints aren't viral anymore, but are implied! This gets rid of all the where constraints on structs and implementations!
  • With the new MSRV, we can now implement Error for our error types without std as well.
  • Move de/serialization constraints on implementations directly onto Group, now that the constraints aren't viral anymore.

This is a huge improvement to the documentation as well, which was littered with these huge where-clauses.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2025
@daxpedda daxpedda mentioned this pull request Apr 15, 2025
Draft
@daxpedda
Bump MSRV to v1.83
c8c3201 
Signed-off-by: daxpedda <daxpedda@gmail.com>
@daxpedda daxpedda changed the title Bump MSRV to Rust v1.83 Bump MSRV to v1.83 Apr 15, 2025
@daxpedda daxpedda mentioned this pull request Apr 15, 2025
Merged
kevinlewi
kevinlewi approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@kevinlewi kevinlewi merged commit 0473d9d into facebook:main Apr 15, 2025
29 checks passed
@raphaelrobert raphaelrobert mentioned this pull request Nov 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daxpedda @kevinlewi @facebook-github-bot