Skip to content

Commit

Permalink
Enable Criterion csv feature
Browse files Browse the repository at this point in the history
Summary:
Criterion was upgraded from 0.3.1 => 0.5.1 in D67343684. Csv output is an optional feature in newer versions and currently required by the servicelab rust benchmark target.

Longer term, cargo-criterion is the recommended plugin for parsable output.

Reviewed By: dtolnay

Differential Revision:
D67454762

Privacy Context Container: L1246866

fbshipit-source-id: 7491decb215feab701ed4bca040182c3a844d92d
  • Loading branch information
Russ Weingarten authored and facebook-github-bot committed Dec 20, 2024
1 parent 2b562a4 commit bb4c06f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion eden/fs/benchmarks/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ name = "benchmarks"
path = "benchmarks.rs"

[dependencies]
criterion = "0.5.1"
criterion = { version = "0.5.1", features = ["csv_output"] }
rand = { version = "0.8", features = ["small_rng"] }

[target.'cfg(target_os = "linux")'.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion eden/mononoke/benchmarks/storage_config/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ blobstore_factory = { version = "0.1.0", path = "../../blobstore/factory" }
cacheblob = { version = "0.1.0", path = "../../blobstore/cacheblob" }
clap = { version = "4.5.20", features = ["derive", "env", "string", "unicode", "wrap_help"] }
context = { version = "0.1.0", path = "../../server/context" }
criterion = "0.5.1"
criterion = { version = "0.5.1", features = ["csv_output"] }
environment = { version = "0.1.0", path = "../../cmdlib/environment" }
fbinit = { version = "0.2.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
futures = { version = "0.3.30", features = ["async-await", "compat"] }
Expand Down

0 comments on commit bb4c06f

Please sign in to comment.