Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API AdvancedColumnFamilyOptions::rate_limit_delay_max_milliseconds #9455

Closed
wants to merge 1 commit into from
Closed

Remove deprecated API AdvancedColumnFamilyOptions::rate_limit_delay_max_milliseconds #9455

wants to merge 1 commit into from

Conversation

hx235
Copy link
Contributor

@hx235 hx235 commented Jan 27, 2022 •
edited
Loading

Context/Summary:
AdvancedColumnFamilyOptions::rate_limit_delay_max_milliseconds has been marked as deprecated and it's time to actually remove the code.

  • Keep soft_rate_limit/hard_rate_limit in cf_mutable_options_type_info to prevent throwing InvalidArgument in GetColumnFamilyOptionsFromMap when reading an option file still with these options (e.g, old option file generated from RocksDB before the deprecation)
  • Keep soft_rate_limit/hard_rate_limit in under OptionsOldApiTest.GetOptionsFromMapTest to test the case mentioned above.
    Test:
    Rely on my eyeball and CI

@hx235
Copy link
Contributor Author

hx235 commented Jan 27, 2022 •
edited
Loading

Rebase and merge after #9452

@hx235 hx235 force-pushed the rocksdb7.0_dep_rate_limit_delay_max_milliseconds branch from 2ee2656 to 74cf86b Compare January 27, 2022 01:41
ajkr
ajkr requested changes Jan 27, 2022
View reviewed changes
options/cf_options.cc Outdated
Comment on lines 549 to 554
{"rate_limit_delay_max_milliseconds",
{0, OptionType::kUInt, OptionVerificationType::kDeprecated,
OptionTypeFlags::kNone}},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to leave this. Apparently kDeprecated in this context means unsupported or removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - same for my other PR too.

@hx235 hx235 force-pushed the rocksdb7.0_dep_rate_limit_delay_max_milliseconds branch from 74cf86b to 62ae476 Compare January 27, 2022 07:33
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 requested a review from ajkr January 27, 2022 17:29
ajkr
ajkr approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hx235 hx235 force-pushed the rocksdb7.0_dep_rate_limit_delay_max_milliseconds branch from 62ae476 to 1c43c91 Compare January 27, 2022 21:10
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 force-pushed the rocksdb7.0_dep_rate_limit_delay_max_milliseconds branch from 1c43c91 to 2f8faff Compare January 28, 2022 04:38
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235
Copy link
Contributor Author

hx235 commented Jan 28, 2022

Rebase onto upstream/main for clean CI test

@hx235 hx235 force-pushed the rocksdb7.0_dep_rate_limit_delay_max_milliseconds branch from 2f8faff to 9fd135d Compare January 28, 2022 18:43
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 force-pushed the rocksdb7.0_dep_rate_limit_delay_max_milliseconds branch from 9fd135d to cb90837 Compare January 28, 2022 21:39
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@akrylysov akrylysov mentioned this pull request Feb 2, 2022
Merged
@jamesbibby jamesbibby mentioned this pull request Jun 22, 2023
Open
@jamesbibby jamesbibby mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hx235 @facebook-github-bot @ajkr