Remove deprecated option DBOptions::max_mem_compaction_level #9446
Conversation
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
options/cf_options.cc
Outdated
| {"max_mem_compaction_level", | ||
| {0, OptionType::kInt, OptionVerificationType::kDeprecated, | ||
| OptionTypeFlags::kNone}}, |
There was a problem hiding this comment.
Need to keep this to be able to read old OPTIONS files.
There was a problem hiding this comment.
Good catch, thanks.
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
bjlemaire
force-pushed
the
remove_deprecated_max_mem_compaction_level
branch
from
1a6635b to
ce9409c
Compare
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bjlemaire
force-pushed
the
remove_deprecated_max_mem_compaction_level
branch
from
ec0d34e to
3d3026b
Compare
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bjlemaire
force-pushed
the
remove_deprecated_max_mem_compaction_level
branch
from
3d3026b to
7ad4119
Compare
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bjlemaire
force-pushed
the
remove_deprecated_max_mem_compaction_level
branch
from
7ad4119 to
141ee45
Compare
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bjlemaire
force-pushed
the
remove_deprecated_max_mem_compaction_level
branch
from
141ee45 to
d117d30
Compare
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…e for legacy OPTIONS file read support.
bjlemaire
force-pushed
the
remove_deprecated_max_mem_compaction_level
branch
from
c7d43e1 to
51bb77f
Compare
|
@bjlemaire has updated the pull request. You must reimport the pull request before landing. |
|
@bjlemaire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
In RocksDB, this option was already marked as "NOT SUPPORTED" for a long time, and setting this option does not have any effect on the behavior of RocksDB library. Therefore, we are removing it in the preparations of the upcoming 7.0 release.