[ResourceMngmt] Add new API CacheReservationManager::GetDummyEntrySize() #9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hx235
force-pushed
the
crm_get_dummy_entry_size
branch
2 times, most recently
from
e47e874 to
03c7e27
Compare
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
hx235
force-pushed
the
crm_get_dummy_entry_size
branch
from
03c7e27 to
ed85f45
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
Update:
|
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: it might conflict with another CRM related PR #9071 and so will merge after that's merged.
Context:
As
CacheReservationManagerbeing used by more memory users, it is convenient to retrieve the dummy entry size forCacheReservationManagerinstead of hard-coding256 * 1024in writing tests. Plus it allows more flexibility to change our implementation on dummy entry size.A follow-up PR is needed to replace those hard-coded dummy entry size value in
db_test2.cc,db_write_buffer_manager_test.cc,write_buffer_manager_test.cc,table_test.ccand the ones introduced in #9072 (comment).Summary:
kDummyEntrySizethrough public staticCacheReservationManager::GetDummyEntrySize()Test: