Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EventListener into a Customizable Class #8473

Closed
wants to merge 6 commits into from
Closed

Make EventListener into a Customizable Class #8473

wants to merge 6 commits into from

Conversation

mrambacher
Copy link
Contributor

  • Added Type/CreateFromString
  • Added ability to load EventListeners to DBOptions
  • Since EventListeners did not previously have a Name(), defaulted to "". If there is no name, the listener cannot be loaded from the ObjectRegistry.

@mrambacher
Make EventListener into a Customizable Class
446179b 
- Added Type/CreateFromString
- Added ability to load EventListeners to DBOptions
- Since EventListeners did not previously have a Name(), defaulted to "".  If there is no name, the listener cannot be loaded from the ObjectRegistry.
zhichao-cao
zhichao-cao reviewed Jul 23, 2021
View reviewed changes
options/db_options.cc
@@ -433,6 +433,61 @@ static std::unordered_map<std::string, OptionTypeInfo>
{offsetof(struct ImmutableDBOptions, allow_data_in_errors),
OptionType::kBoolean, OptionVerificationType::kNormal,
OptionTypeFlags::kNone}},
{"listeners",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here to indicate that different EventListener can be create from an option string and also we can serialize it. It would be better to give an example of the string input and the serialized output in the comment.

zhichao-cao
zhichao-cao approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@zhichao-cao zhichao-cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, may be mention that make EventListener in the Customizable class in the HISTORY.md.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrambacher has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mrambacher mrambacher force-pushed the CustomEventListener branch from b9aa8b0 to b2ce708 Compare July 27, 2021 09:27
@facebook-github-bot
Copy link
Contributor

@mrambacher has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrambacher merged this pull request in 3aee4fb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichao-cao zhichao-cao zhichao-cao approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrambacher @facebook-github-bot @zhichao-cao