Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jemalloc_helper: Limit the mm_malloc.h hack to glibc on linux #8425

Closed
wants to merge 1 commit into from
Closed

jemalloc_helper: Limit the mm_malloc.h hack to glibc on linux #8425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
jemalloc_helper: Limit the mm_malloc.h hack to glibc on linux 
Original author: @kraj (#8413)

We have a hack to ensure clang's `posix_memalign()` hack works to be
compatible with glibc's `posix_memalign()` declaration. Our side of the
hack is irrelevant and should be omitted when not using glibc.
  • Loading branch information
@ajkr
ajkr committed Jun 18, 2021
commit 9736121720c6cb374855fc6422a69da432cca96b
2 changes: 1 addition & 1 deletion port/jemalloc_helper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#pragma once

#if defined(__clang__)
#if defined(__clang__) && defined(__GLIBC__)
// glibc's `posix_memalign()` declaration specifies `throw()` while clang's
// declaration does not. There is a hack in clang to make its re-declaration
// compatible with glibc's if they are declared consecutively. That hack breaks
Expand Down