Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

range_tree requires GNU libc on ppc64 #8070

Closed
wants to merge 5 commits into from
Closed

range_tree requires GNU libc on ppc64 #8070

wants to merge 5 commits into from

Conversation

adamretter
Copy link
Collaborator

If the platform is ppc64 and the libc is not GNU libc, then we exclude the range_tree from compilation.

See https://jira.percona.com/browse/PS-7559

@adamretter adamretter force-pushed the hotfix/ppc-non-gnu-exclude-range-lock branch from a0bcd62 to 4d37a7c Compare March 17, 2021 21:45
@adamretter adamretter requested a review from jay-zhuang March 17, 2021 21:45
@adamretter adamretter requested a review from mrambacher March 17, 2021 21:45
@adamretter adamretter added ppc64le bug Confirmed RocksDB bugs regression labels Mar 17, 2021
@adamretter
Copy link
Collaborator Author

Tests are running on pcc64le...

mrambacher
mrambacher reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the same changes also apply to CMAKE?

What about CLANG or is that not an issue?

build_tools/build_detect_platform Show resolved Hide resolved
src.mk Outdated Show resolved Hide resolved
src.mk Outdated Show resolved Hide resolved
@adamretter adamretter force-pushed the hotfix/ppc-non-gnu-exclude-range-lock branch from 09a6f56 to b807b2d Compare March 18, 2021 21:11
@adamretter adamretter mentioned this pull request Mar 18, 2021
Closed
@adamretter adamretter marked this pull request as ready for review March 18, 2021 21:52
@adamretter
Copy link
Collaborator Author

Does the same changes also apply to CMAKE?

@mrambacher It might need to be done for CMake, but I fixed this predominantly for ppc64le and Make. If someone needs CMake on pcc64le we could take a look later, or would you rather I attempt and fix that in this PR too?

What about CLANG or is that not an issue?
This only checks if GNU libc is absent on ppc64le. If the libc from llvm project is used instead of gnu, then this will still correctly check that.

mrambacher
mrambacher reviewed Mar 22, 2021
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarity, can you outline how this works? This must only work because there is no public API to use this lock manager code?

This looks like a prime candidate for something that should be a plugin and NOT in the main source tree (not suggesting that as part of this PR but...)

@adamretter
Copy link
Collaborator Author

This must only work because there is no public API to use this lock manager code?

@mrambacher I think it was explained to me that this code is compiled but not actually used yet.

This looks like a prime candidate for something that should be a plugin and NOT in the main source tree (not suggesting that as part of this PR but...)

I think it is anticipated that range_tree will be used from the Transactions classes, but I am not certain.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mrambacher
mrambacher approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

jay-zhuang
jay-zhuang approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@jay-zhuang jay-zhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc. @spetrunia

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrambacher merged this pull request in 24b7ebe.

jay-zhuang pushed a commit that referenced this pull request Mar 30, 2021
@adamretter @jay-zhuang
range_tree requires GNU libc on ppc64 (#8070)
5884cf5 
Summary:
If the platform is ppc64 and the libc is not GNU libc, then we exclude the range_tree from compilation.

See https://jira.percona.com/browse/PS-7559

Pull Request resolved: #8070

Reviewed By: jay-zhuang

Differential Revision: D27246004

Pulled By: mrambacher

fbshipit-source-id: 59d8433242ce7ce608988341becb4f83312445f5
jay-zhuang pushed a commit that referenced this pull request Mar 30, 2021
@adamretter @jay-zhuang
range_tree requires GNU libc on ppc64 (#8070)
60c1321 
Summary:
If the platform is ppc64 and the libc is not GNU libc, then we exclude the range_tree from compilation.

See https://jira.percona.com/browse/PS-7559

Pull Request resolved: #8070

Reviewed By: jay-zhuang

Differential Revision: D27246004

Pulled By: mrambacher

fbshipit-source-id: 59d8433242ce7ce608988341becb4f83312445f5
jay-zhuang pushed a commit that referenced this pull request Mar 30, 2021
@adamretter @jay-zhuang
range_tree requires GNU libc on ppc64 (#8070)
1cdc065 
Summary:
If the platform is ppc64 and the libc is not GNU libc, then we exclude the range_tree from compilation.

See https://jira.percona.com/browse/PS-7559

Pull Request resolved: #8070

Reviewed By: jay-zhuang

Differential Revision: D27246004

Pulled By: mrambacher

fbshipit-source-id: 59d8433242ce7ce608988341becb4f83312445f5
jay-zhuang pushed a commit that referenced this pull request Mar 30, 2021
@adamretter @jay-zhuang
range_tree requires GNU libc on ppc64 (#8070)
9435b2e 
Summary:
If the platform is ppc64 and the libc is not GNU libc, then we exclude the range_tree from compilation.

See https://jira.percona.com/browse/PS-7559

Pull Request resolved: #8070

Reviewed By: jay-zhuang

Differential Revision: D27246004

Pulled By: mrambacher

fbshipit-source-id: 59d8433242ce7ce608988341becb4f83312445f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay-zhuang jay-zhuang jay-zhuang approved these changes

@mrambacher mrambacher mrambacher approved these changes

Assignees
No one assigned
Labels
bug Confirmed RocksDB bugs CLA Signed Merged ppc64le regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamretter @facebook-github-bot @jay-zhuang @mrambacher