[CodeMod] Remove unused includes #7604
Conversation
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Can I ask how this tool decides what can be removed?
Personally, the problem I see is that a lot of header files include things that they should not. Some are unnecessary includes and some should be forward declares. I view cleaning those header files up as much more bang for the buck than cleaning up C++ files.
It was generated by an internal src code analysis service, and I am not sure about the implementation. An internal diff was generated, then I applied the diff to Github repo as a test. The way header files are organized can be improved. In addition to that, I think part of this PR does the job by removing unnecessary inclusion of system headers, unnecessary |
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
riversand963
changed the title
|
Is there anything that influence the windows build and testing? |
riversand963
force-pushed
the
remove-dead-includes-codemod
branch
from
4d2f27c to
136550d
Compare
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@riversand963 merged this pull request in 394210f. |
Summary: This is a PR generated **semi-automatically** by an internal tool to remove unused includes and `using` statements. Pull Request resolved: facebook#7604 Test Plan: make check Reviewed By: ajkr Differential Revision: D24579392 Pulled By: riversand963 fbshipit-source-id: c4bfa6c6b08da1de186690d37eb73d8fff45aecd
Summary: This is a PR generated **semi-automatically** by an internal tool to remove unused includes and `using` statements. Pull Request resolved: facebook/rocksdb#7604 Test Plan: make check Reviewed By: ajkr Differential Revision: D24579392 Pulled By: riversand963 fbshipit-source-id: c4bfa6c6b08da1de186690d37eb73d8fff45aecd Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: This is a PR generated **semi-automatically** by an internal tool to remove unused includes and `using` statements. Pull Request resolved: facebook/rocksdb#7604 Test Plan: make check Reviewed By: ajkr Differential Revision: D24579392 Pulled By: riversand963 fbshipit-source-id: c4bfa6c6b08da1de186690d37eb73d8fff45aecd Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: This is a PR generated **semi-automatically** by an internal tool to remove unused includes and `using` statements. Pull Request resolved: facebook/rocksdb#7604 Test Plan: make check Reviewed By: ajkr Differential Revision: D24579392 Pulled By: riversand963 fbshipit-source-id: c4bfa6c6b08da1de186690d37eb73d8fff45aecd Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: This is a PR generated **semi-automatically** by an internal tool to remove unused includes and `using` statements. Pull Request resolved: facebook/rocksdb#7604 Test Plan: make check Reviewed By: ajkr Differential Revision: D24579392 Pulled By: riversand963 fbshipit-source-id: c4bfa6c6b08da1de186690d37eb73d8fff45aecd Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: This is a PR generated **semi-automatically** by an internal tool to remove unused includes and `using` statements. Pull Request resolved: facebook/rocksdb#7604 Test Plan: make check Reviewed By: ajkr Differential Revision: D24579392 Pulled By: riversand963 fbshipit-source-id: c4bfa6c6b08da1de186690d37eb73d8fff45aecd Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: This is a PR generated **semi-automatically** by an internal tool to remove unused includes and `using` statements. Pull Request resolved: facebook/rocksdb#7604 Test Plan: make check Reviewed By: ajkr Differential Revision: D24579392 Pulled By: riversand963 fbshipit-source-id: c4bfa6c6b08da1de186690d37eb73d8fff45aecd Signed-off-by: Changlong Chen <levisonchen@live.cn>
This is a PR generated semi-automatically by an internal tool to remove unused includes and
usingstatements.Test plan:
make check