Fix Java test for uint64add merge operator #7243
Conversation
|
Hi @shirolimit! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
shirolimit
force-pushed
the
fix-java-merge-operator-test
branch
from
7dec6e3 to
7643834
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hmm, it seems that one of the Travis CI jobs has timed out. I don't think that it is relevant to the PR. |
|
@shirolimit It happens from time to time. I have restarted it... |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@adamretter got it, thank you. Looks like all checks have passed |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger merged this pull request in 2bc63e3. |
Summary: The PR fixes a Java test for Merge operator `uint64add`. The current implementation uses wrong byte order for long serialization, but fails to catch this error because the merge sum is lower than `256`. The PR makes this test case more representative (i.e. it fails with wrong byte order) and changes the byte order to little endian. Some background: RocksDB uses LittleEndian byte order for integer serialization across all platforms. `MergeTest` uses `ByteBuffer` that defaults to BigEndian byte order. This test case might probably be used as a sample of `MergeOperator` usage in Java. Pull Request resolved: facebook#7243 Reviewed By: ajkr Differential Revision: D23079593 Pulled By: pdillinger fbshipit-source-id: 82e8e166901d66733e96a0116f88d0ec4761ddf1
3 participants
The PR fixes a Java test for Merge operator
uint64add.The current implementation uses wrong byte order for long serialization, but fails to catch this error because the merge sum is lower than
256.The PR makes this test case more representative (i.e. it fails with wrong byte order) and changes the byte order to little endian.
Some background: RocksDB uses LittleEndian byte order for integer serialization across all platforms.
MergeTestusesByteBufferthat defaults to BigEndian byte order.This test case might probably be used as a sample of
MergeOperatorusage in Java.