Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with GCC9 and MSVC 2019 with CMAKE_CXX_STANDARD=20 #6648

Closed
wants to merge 12 commits into from
Closed
Prev Previous commit
Fix whitespace / noeol in CMakeLists.txt
  • Loading branch information
pdillinger committed Apr 10, 2020
commit 831fb29a12b0441a8b161a3218686fe519af17cf
10 changes: 5 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ if(MSVC)
else()
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /Gm")
endif()

endif()
if(WITH_RUNTIME_DEBUG)
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /${RUNTIME_LIBRARY}d")
Expand Down Expand Up @@ -507,7 +507,7 @@ if(HAVE_AUXV_GETAUXVAL)
add_definitions(-DROCKSDB_AUXV_GETAUXVAL_PRESENT)
endif()

# Workaround to get c++ std version option coming from CMAKE_CXX_STANDARD for try_compile
# Workaround to get c++ std version option coming from CMAKE_CXX_STANDARD for try_compile
include(CxxFlags)
get_cxx_std_flags(CMAKE_REQUIRED_FLAGS)

Expand All @@ -519,7 +519,7 @@ int apply(F f) {

struct test {
test() : value_(0) {}

int lambda() {
return apply([=]() {
return value_;
Expand Down Expand Up @@ -992,7 +992,7 @@ if(WITH_TESTS)
add_library(testharness STATIC
test_util/testharness.cc)
target_link_libraries(testharness gtest)

set(TESTS
cache/cache_test.cc
cache/lru_cache_test.cc
Expand Down Expand Up @@ -1269,4 +1269,4 @@ if(WITH_TOOLS)
add_subdirectory(db_stress_tool)
add_custom_target(tools
DEPENDS ${tool_deps})
endif()
endif()