Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index value delta encoding #3983

Closed
wants to merge 10 commits into from
Closed

Index value delta encoding #3983

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cac9c0b
write path
Jun 7, 2018
f04b570
make format
Aug 8, 2018
ced2778
fix appvoyer complaint
Aug 8, 2018
6606844
rename UpdateSize to set_size
Aug 8, 2018
d14a031
apply comments
Aug 9, 2018
0cfb0ba
use data_ + restarts_ for limit
Aug 9, 2018
75dc31c
apply comments 2
Aug 9, 2018
d74b876
apply comments 3
Aug 9, 2018
ce8f236
switch to zigzag format
Aug 9, 2018
1200fea
fix window warning
Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix appvoyer complaint
  • Loading branch information
Maysam Yabandeh committed Aug 8, 2018
commit ced2778eda427f9872ec47af89bce194950b22ba
6 changes: 3 additions & 3 deletions table/iterator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ Iterator* NewErrorIterator(const Status& status) {
return new EmptyIterator(status);
}

template <class TValue = Slice>
template <class TValue>
InternalIteratorBase<TValue>* NewErrorInternalIterator(const Status& status) {
return new EmptyInternalIterator<TValue>(status);
}
Expand All @@ -174,7 +174,7 @@ template InternalIteratorBase<BlockHandle>* NewErrorInternalIterator(
template InternalIteratorBase<Slice>* NewErrorInternalIterator(
const Status& status);

template <class TValue = Slice>
template <class TValue>
InternalIteratorBase<TValue>* NewErrorInternalIterator(const Status& status,
Arena* arena) {
if (arena == nullptr) {
Expand All @@ -196,7 +196,7 @@ InternalIteratorBase<TValue>* NewEmptyInternalIterator() {
template InternalIteratorBase<BlockHandle>* NewEmptyInternalIterator();
template InternalIteratorBase<Slice>* NewEmptyInternalIterator();

template <class TValue = Slice>
template <class TValue>
InternalIteratorBase<TValue>* NewEmptyInternalIterator(Arena* arena) {
if (arena == nullptr) {
return NewEmptyInternalIterator<TValue>();
Expand Down