Fix an internal comment about resumable compaction #14215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaykorean
approved these changes
Jan 6, 2026
Contributor
jaykorean
left a comment
jaykorean
left a comment
There was a problem hiding this comment.
This PR made me read through the code again and wonder if we want to return a different status when we encounter an IO error during ReadOutputFilesTableProperties(). With current logic, MaybeResumeSubcompactionProgressOnInputIterator() would return Status::Corruption() when ReadOutputFilesTableProperties() returns any non-ok status.
Let's discuss this separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Summary: as titled
Test plan: no code change