Fix CondVar::TimedWait for Windows #12815
Conversation
|
Hi @eniac1024! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
eniac1024
changed the title
You're right, it's a generalized workaround, and the title was confusing. This issue started when compiling with VS2019 (which upticked the STL version). Everything was working fine with previous VS version. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
CI complains about code format. Need to run |
|
@eniac1024 has updated the pull request. You must reimport the pull request before landing. |
Done |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Based on microsoft/STL#369
They fixed the issue in
std::condition_variable_anybut not instd::condition_variable, which is currently used in rocksdb repo. So we need to implement the work around regardless of_MSVC_STL_UPDATE.