Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default cf ts sz for a reused transaction #11685

Closed
wants to merge 1 commit into from

Conversation

jowlyzhang
Copy link
Contributor

Set up the default column family timestamp size for a reused write committed transaction.

Test plan:
Added unit test.

@jowlyzhang jowlyzhang requested a review from ltamasi August 9, 2023 16:43
@facebook-github-bot
Copy link
Contributor

@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ltamasi ltamasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @jowlyzhang !

@jowlyzhang
Copy link
Contributor Author

LGTM, thanks for the fix @jowlyzhang !

Thank you for the quick review!

@facebook-github-bot
Copy link
Contributor

@jowlyzhang merged this pull request in c751583.

@jowlyzhang jowlyzhang deleted the default_cf_ts_sz branch August 11, 2023 20:58
rockeet pushed a commit to topling/toplingdb that referenced this pull request Dec 18, 2023
Summary:
Set up the default column family timestamp size for a reused write committed transaction.

Pull Request resolved: facebook/rocksdb#11685

Test Plan: Added unit test.

Reviewed By: ltamasi

Differential Revision: D48195129

Pulled By: jowlyzhang

fbshipit-source-id: 54faa900c123fc6daa412c01490e36c10a24a678
rockeet pushed a commit to topling/toplingdb that referenced this pull request Sep 1, 2024
Summary:
Set up the default column family timestamp size for a reused write committed transaction.

Pull Request resolved: facebook/rocksdb#11685

Test Plan: Added unit test.

Reviewed By: ltamasi

Differential Revision: D48195129

Pulled By: jowlyzhang

fbshipit-source-id: 54faa900c123fc6daa412c01490e36c10a24a678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants