Remove some useless qualifier #11596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
force-pushed
the
remove-virtual
branch
from
ba8737e
to
07592e1
Compare
jowlyzhang
reviewed
Jul 19, 2023
| @@ -51,13 +48,13 @@ class IndexBuilder { | |||
| Slice index_block_contents; | |||
| std::unordered_map<std::string, Slice> meta_blocks; | |||
| }; | |||
| explicit IndexBuilder(const InternalKeyComparator* comparator, size_t ts_sz, | |||
| bool persist_user_defined_timestamps) | |||
| IndexBuilder(const InternalKeyComparator* comparator, size_t ts_sz, | |||
There was a problem hiding this comment.
Would you mind help removing the explicit qualifier from the constructors for some other IndexBuilder subclasses in this file?
jowlyzhang
approved these changes
Jul 19, 2023
darionyaphet
force-pushed
the
remove-virtual
branch
2 times, most recently
from
5cb1da8
to
3ad1273
Compare
darionyaphet
force-pushed
the
remove-virtual
branch
from
3ad1273
to
48d8937
Compare
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jowlyzhang merged this pull request in df54346. |
rockeet
pushed a commit
to topling/toplingdb
that referenced
this pull request
Dec 18, 2023
Summary: Pull Request resolved: facebook/rocksdb#11596 Reviewed By: ajkr Differential Revision: D47635614 Pulled By: jowlyzhang fbshipit-source-id: 651a06049a54d15fd4b4f010bb4b82f53ff9c9d4
rockeet
pushed a commit
to topling/toplingdb
that referenced
this pull request
Sep 1, 2024
Summary: Pull Request resolved: facebook/rocksdb#11596 Reviewed By: ajkr Differential Revision: D47635614 Pulled By: jowlyzhang fbshipit-source-id: 651a06049a54d15fd4b4f010bb4b82f53ff9c9d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.