Delete temp OPTIONS file on failure to write it #11423
Conversation
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
db/db_impl/db_impl.cc
Outdated
| @@ -4909,7 +4909,14 @@ Status DBImpl::WriteOptionsFile(bool need_mutex_lock, | |||
|
|
|||
| if (s.ok()) { | |||
| s = RenameTempFileToOptionsFile(file_name); | |||
| } else { | |||
There was a problem hiding this comment.
So just to confirm, It won't consider failure in renaming the file as the deletion check is inside the else statement?
There was a problem hiding this comment.
Good point. Its the same situation if rename fails - the temp OPTIONS file is not deleted. It needs to be handled.
|
@anand1976 has updated the pull request. You must reimport the pull request before landing. |
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@anand1976 has updated the pull request. You must reimport the pull request before landing. |
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@anand1976 merged this pull request in 2084cdf. |
When the DB is opened, RocksDB creates a temp OPTIONS file, writes the current options to it, and renames it. In case of a failure, the temp file is left behind, and is not deleted by PurgeObsoleteFiles(). Fix this by explicitly deleting the temp file if writing to it or renaming it fails.
Test plan:
Add a unit test