-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New stat rocksdb.{cf|db}-write-stall-stats exposed in a structural way #11300
Conversation
8a850a5
to
ce6ca96
Compare
5e4c523
to
3c4513f
Compare
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3c4513f
to
0115d0e
Compare
@hx235 has updated the pull request. You must reimport the pull request before landing. |
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
0115d0e
to
9b5dccc
Compare
@hx235 has updated the pull request. You must reimport the pull request before landing. |
9b5dccc
to
5703d3e
Compare
@hx235 has updated the pull request. You must reimport the pull request before landing. |
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
5703d3e
to
146e85d
Compare
@hx235 has updated the pull request. You must reimport the pull request before landing. |
146e85d
to
ad65143
Compare
@hx235 has updated the pull request. You must reimport the pull request before landing. |
ad65143
to
a1fa82a
Compare
@hx235 has updated the pull request. You must reimport the pull request before landing. |
a1fa82a
to
2081d6c
Compare
@hx235 has updated the pull request. You must reimport the pull request before landing. |
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. @update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Upstream commit ID: facebook/mysql-5.6@2ece56e PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: update rocksdb to 8.1.fb rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note > Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map. see also facebook/rocksdb#11300. update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D44687471 fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Context/Summary:
Users are interested in figuring out what has caused write stall.
Refactor write stall related stats from property
kCFStats
into its own db propertyrocksdb.cf-write-stall-stats
as a map or string. For now, this only contains count of different combination of (CF-scopeWriteStallCause
) + (WriteStallCondition
)Add new
WriteStallCause::kWriteBufferManagerLimit
to reflect write stall caused by write buffer managerAdd new
rocksdb.db-write-stall-stats
. For now, this only containsWriteStallCause::kWriteBufferManagerLimit
+WriteStallCondition::kStopped
Expose functions in new class
WriteStallStatsMapKeys
for examining the above two properties returned as mapMisc: rename/comment some write stall InternalStats for clarity
Test:
python3 tools/db_crashtest.py blackbox --simple --get_property_one_in=1
pre-change:
post-change: