Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New stat rocksdb.{cf|db}-write-stall-stats exposed in a structural way #11300

Closed
wants to merge 4 commits into from

Conversation

hx235
Copy link
Contributor

@hx235 hx235 commented Mar 16, 2023

Context/Summary:
Users are interested in figuring out what has caused write stall.

  • Refactor write stall related stats from property kCFStats into its own db property rocksdb.cf-write-stall-stats as a map or string. For now, this only contains count of different combination of (CF-scope WriteStallCause) + (WriteStallCondition)

  • Add new WriteStallCause::kWriteBufferManagerLimit to reflect write stall caused by write buffer manager

  • Add new rocksdb.db-write-stall-stats. For now, this only contains WriteStallCause::kWriteBufferManagerLimit + WriteStallCondition::kStopped

  • Expose functions in new class WriteStallStatsMapKeys for examining the above two properties returned as map

  • Misc: rename/comment some write stall InternalStats for clarity

Test:

  • New UT
  • Stress test
    python3 tools/db_crashtest.py blackbox --simple --get_property_one_in=1
  • Perf test: Both converge very slowly at similar rates but post-change has higher average ops/sec than pre-change even though they are run at the same time.
./db_bench -seed=1679014417652004 -db=/dev/shm/testdb/ -statistics=false -benchmarks="fillseq[-X60]" -key_size=32 -value_size=512 -num=100000 -db_write_buffer_size=655 -target_file_size_base=655 -disable_auto_compactions=false -compression_type=none -bloom_bits=3

pre-change:

fillseq [AVG 15 runs] : 1176 (± 732) ops/sec;    0.6 (± 0.4) MB/sec
fillseq      :    1052.671 micros/op 949 ops/sec 105.267 seconds 100000 operations;    0.5 MB/s
fillseq [AVG 16 runs] : 1162 (± 685) ops/sec;    0.6 (± 0.4) MB/sec
fillseq      :    1387.330 micros/op 720 ops/sec 138.733 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 17 runs] : 1136 (± 646) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1232.011 micros/op 811 ops/sec 123.201 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 18 runs] : 1118 (± 610) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1282.567 micros/op 779 ops/sec 128.257 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 19 runs] : 1100 (± 578) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1914.336 micros/op 522 ops/sec 191.434 seconds 100000 operations;    0.3 MB/s
fillseq [AVG 20 runs] : 1071 (± 551) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1227.510 micros/op 814 ops/sec 122.751 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 21 runs] : 1059 (± 525) ops/sec;    0.5 (± 0.3) MB/sec

post-change:

fillseq [AVG 15 runs] : 1226 (± 732) ops/sec;    0.6 (± 0.4) MB/sec
fillseq      :    1323.825 micros/op 755 ops/sec 132.383 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 16 runs] : 1196 (± 687) ops/sec;    0.6 (± 0.4) MB/sec
fillseq      :    1223.905 micros/op 817 ops/sec 122.391 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 17 runs] : 1174 (± 647) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1168.996 micros/op 855 ops/sec 116.900 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 18 runs] : 1156 (± 611) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1348.729 micros/op 741 ops/sec 134.873 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 19 runs] : 1134 (± 579) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1196.887 micros/op 835 ops/sec 119.689 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 20 runs] : 1119 (± 550) ops/sec;    0.6 (± 0.3) MB/sec
fillseq      :    1193.697 micros/op 837 ops/sec 119.370 seconds 100000 operations;    0.4 MB/s
fillseq [AVG 21 runs] : 1106 (± 524) ops/sec;    0.6 (± 0.3) MB/sec

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch 5 times, most recently from 8a850a5 to ce6ca96 Compare March 17, 2023 05:43
@hx235 hx235 changed the title [Draft] New stat rocksdb.cf-write-stall-stats exposed in structural map New stat rocksdb.cf-write-stall-stats exposed in structural map Mar 17, 2023
@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch 2 times, most recently from 5e4c523 to 3c4513f Compare March 17, 2023 06:02
include/rocksdb/listener.h Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch from 3c4513f to 0115d0e Compare March 17, 2023 06:23
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@hx235 hx235 changed the title New stat rocksdb.cf-write-stall-stats exposed in structural map New stat rocksdb.cf-write-stall-stats exposed in structural Mar 17, 2023
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch from 0115d0e to 9b5dccc Compare March 17, 2023 08:16
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch from 9b5dccc to 5703d3e Compare March 17, 2023 08:22
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@hx235 hx235 requested a review from ajkr March 17, 2023 10:09
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch from 5703d3e to 146e85d Compare March 18, 2023 01:01
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch from 146e85d to ad65143 Compare March 18, 2023 01:04
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch from ad65143 to a1fa82a Compare March 18, 2023 01:06
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@hx235 hx235 force-pushed the expose_write_stall_cause_stat branch from a1fa82a to 2081d6c Compare March 18, 2023 01:08
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 18, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 29, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request May 13, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request May 24, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request May 27, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request May 31, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 5, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 10, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 12, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 12, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Jul 25, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Jul 30, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 2, 2024
Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

@update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Aug 21, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Aug 28, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Aug 30, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to percona/percona-server that referenced this pull request Sep 23, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to percona/percona-server that referenced this pull request Sep 25, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to inikep/percona-server that referenced this pull request Sep 25, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Oct 17, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Oct 17, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Oct 22, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to inikep/percona-server that referenced this pull request Oct 28, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to percona/percona-server that referenced this pull request Oct 30, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 11, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 14, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 14, 2024
Upstream commit ID: facebook/mysql-5.6@2ece56e
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
update rocksdb to 8.1.fb

rocksdb api change causing `io_stalls` properties no long exist. see rocksdb release note
> Add new db properties `rocksdb.cf-write-stall-stats`, `rocksdb.db-write-stall-stats`and APIs to examine them in a structured way. In particular, users of `GetMapProperty()` with property `kCFWriteStallStats`/`kDBWriteStallStats` can now use the functions in `WriteStallStatsMapKeys` to find stats in the map.

see also facebook/rocksdb#11300.

update-submodule: rocksdb

Reviewed By: hermanlee

Differential Revision: D44687471

fbshipit-source-id: 9b62ed10a5e76e68d3197b56c6b2a3ae878807d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants