Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose save points in Java WriteBatch and WBWI #1092

Merged
merged 2 commits into from
Jun 14, 2016

Conversation

adamretter
Copy link
Collaborator

@adamretter adamretter commented Apr 25, 2016

Implemented:

  1. WriteBatch#setSavePoint
  2. WriteBatch#rollbackToSavePoint
  3. WriteBatchWithIndex#setSavePoint
  4. WriteBatchWithIndex#rollbackToSavePoint

* Signature: (J)V
*/
void Java_org_rocksdb_WriteBatch_rollbackToSavePoint0(JNIEnv* env, jobject jobj, jlong jwb_handle) {
auto* wb = reinterpret_cast<rocksdb::WriteBatch*>(jwb_handle);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two space indent instead of four

@yhchiang
Copy link
Contributor

Good stuff! The patch looks good to me. I only have some style-related comments. Once they are addressed it's good to go!

@adamretter adamretter force-pushed the java-wb-save-restore-points branch from dd6d2e7 to 04d286c Compare June 14, 2016 09:47
@adamretter
Copy link
Collaborator Author

@yhchiang Sorry about that, those formatting issues should be addressed now.

@yhchiang yhchiang merged commit e3b1e3d into facebook:master Jun 14, 2016
@yhchiang
Copy link
Contributor

LGTM. Thanks for the contribution!!

@adamretter adamretter deleted the java-wb-save-restore-points branch August 3, 2016 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants