Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with WAL tracking and FlushWAL(true /* sync */) #10185

Closed
wants to merge 14 commits into from
Closed

Fix race condition with WAL tracking and FlushWAL(true /* sync */) #10185

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d87f243
repro test case
ajkr Jun 16, 2022
a9eb7d0
simple solution
ajkr Jun 16, 2022
698b113
fix test issue
ajkr Jun 16, 2022
37872ab
size_t -> uint64_t
ajkr Jun 16, 2022
9e639bc
update HISTORY.md
ajkr Jun 16, 2022
c350b68
update HISTORY.md
ajkr Jun 16, 2022
b1bc913
tracked_synced_size_limit -> pre_sync_size
ajkr Jun 17, 2022
d37b11a
improve checkpoint test
ajkr Jun 17, 2022
908ae50
test exposing we still get synced size too early
ajkr Jun 17, 2022
6d774df
synced size from WritableFileWriter::GetFlushedSize
ajkr Jun 17, 2022
fe38d7a
make format
ajkr Jun 17, 2022
18c7c2b
make flushed_size_ access thread safe
ajkr Jun 17, 2022
424a751
methods for prepare/finish sync
ajkr Jun 17, 2022
4c6cd31
add comment
ajkr Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment
  • Loading branch information
@ajkr
ajkr committed Jun 17, 2022
commit 4c6cd313aca1ef986aba136c09b4bd976139c3ff
4 changes: 4 additions & 0 deletions file/writable_file_writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ class WritableFileWriter {
return filesize_.load(std::memory_order_acquire);
}

// Returns the size of data flushed to the underlying `FSWritableFile`.
// Expected to match `writable_file()->GetFileSize()`.
// The return value can serve as a lower-bound for the amount of data synced
// by a future call to `SyncWithoutFlush()`.
uint64_t GetFlushedSize() const {
return flushed_size_.load(std::memory_order_acquire);
}
Expand Down