Add blob cache option in the column family options #10155
Conversation
There was a problem hiding this comment.
I assume this PR is just adding the option, not the usage of the blob_cache, as I do not see it anywhere?
You need to add tests to option_test to verify that you can properly set the options. And a test that validates the option properly remains as it goes from CFOption - ImmutableCF - CFOption.
Yeah, we plan to split the giant PR to smaller ones. |
There was a problem hiding this comment.
Thanks @gangliao for the PR.
I guess the intention is to announce the feature in HISTORY.md when it's ready?
Yeah, when this PR is merged, I will push more core PRs towards the feature, including HISTORY.md. |
|
@gangliao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: There is currently no caching mechanism for blobs, which is not ideal especially when the database resides on remote storage (where we cannot rely on the OS page cache). As part of this task, we would like to make it possible for the application to configure a blob cache. Test Plan: Reviewers: Subscribers: Tasks: Tags:
gangliao
force-pushed
the
blob_cache_read_p1
branch
from
27ec721
to
09b9b4a
Compare
|
@gangliao has updated the pull request. You must reimport the pull request before landing. |
|
@gangliao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Update HISTORY.md for blob cache. Implementation can be found from Github issue #10156 (or Github PRs #10155, #10178, #10225, #10198, and #10272). Pull Request resolved: #10328 Reviewed By: riversand963 Differential Revision: D37732514 Pulled By: gangliao fbshipit-source-id: 4c942a41c07914bfc8db56a0d3cf4d3e53d5963f
Summary:
There is currently no caching mechanism for blobs, which is not ideal especially when the database resides on remote storage (where we cannot rely on the OS page cache). As part of this task, we would like to make it possible for the application to configure a blob cache.
Tasks:
This PR is a part of #10156