Inconsistence of GetDBOptionsFromMap between implementation and document

[J0HN50N133]

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

Expected behavior

as describe in document:

rocksdb/include/rocksdb/convenience.h

Line 296 in e3024e7

// @return Status::NotFound means the one (or more) of the option name in

This following expression should be true.

GetDBOptionsFromMap(cfg, options, {}, new_options).code() == rocksdb::Status::kNotFound

Actual behavior

But in fact, the expression is false, the status code is rocksdb::Status::InvalidArgument

rocksdb/options/options_helper.cc

Line 734 in e3024e7

if (s.ok() || s.IsInvalidArgument()) {

It seems the implementation translate all error into InvalidArgument for some reasons. The inconsistence between implementation and document is disturbing.