Skip to content

Commit

Permalink
Disable inplace_update_support in transaction stress tests (#12586)
Browse files Browse the repository at this point in the history
Summary:
`MultiOpsTxnsStressTest` relies on snapshot which is incompatible with `inplace_update_support`. TransactionDB uses snapshot too so we don't expect it to be used with `inplace_update_support` either.

Pull Request resolved: #12586

Test Plan:
```
python3 tools/db_crashtest.py whitebox --[test_multiops_txn|txn] --txn_write_policy=1
```

Reviewed By: hx235

Differential Revision: D56602769

Pulled By: cbi42

fbshipit-source-id: 8778541295f0af71e8ce912c8f872ab5cc607fc1
  • Loading branch information
cbi42 authored and facebook-github-bot committed Apr 26, 2024
1 parent 177ccd3 commit d610e14
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tools/db_crashtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,8 @@ def is_direct_io_supported(dbname):
"create_timestamped_snapshot_one_in": random.choice([0, 20]),
# PutEntity in transactions is not yet implemented
"use_put_entity_one_in": 0,
# Should not be used with TransactionDB which uses snapshot.
"inplace_update_support": 0,
}

# For optimistic transaction db
Expand Down Expand Up @@ -607,6 +609,8 @@ def is_direct_io_supported(dbname):
"use_multi_get_entity": 0,
# `MultiOpsTxnsStressTest::TestIterateAgainstExpected()` is not implemented.
"verify_iterator_with_expected_state_one_in": 0,
# This test uses snapshot heavily which is incompatible with this option.
"inplace_update_support": 0,
}

multiops_wc_txn_params = {
Expand Down

0 comments on commit d610e14

Please sign in to comment.