Skip to content

Commit

Permalink
jemalloc_helper: Limit the mm_malloc.h hack to glibc on linux (#8425)
Browse files Browse the repository at this point in the history
Summary:
Original author: kraj (#8413)

We have a hack to ensure clang's `posix_memalign()` hack works to be
compatible with glibc's `posix_memalign()` declaration. Our side of the
hack is irrelevant and should be omitted when not using glibc.

Pull Request resolved: #8425

Reviewed By: mrambacher

Differential Revision: D29239029

Pulled By: ajkr

fbshipit-source-id: 12b900f50a4823b880a6558f25d8590dbfc0aa26
  • Loading branch information
ajkr authored and facebook-github-bot committed Jun 29, 2021
1 parent 390c524 commit bac3994
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion port/jemalloc_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#pragma once

#if defined(__clang__)
#if defined(__clang__) && defined(__GLIBC__)
// glibc's `posix_memalign()` declaration specifies `throw()` while clang's
// declaration does not. There is a hack in clang to make its re-declaration
// compatible with glibc's if they are declared consecutively. That hack breaks
Expand Down

0 comments on commit bac3994

Please sign in to comment.