Skip to content

Commit

Permalink
VerifySstUniqueIds status is overrided for multi CFs
Browse files Browse the repository at this point in the history
Summary: There's bug that basically we only report the last CF's
VerifySstUniqueIds() result:
#9990 (comment)

Test Plan: CI
  • Loading branch information
jay-zhuang committed Jul 15, 2022
1 parent 00e68e7 commit adc3b2e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion db/db_impl/db_impl_open.cc
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ Status DBImpl::VerifySstUniqueIdInManifest() {
"Verifying SST unique id between MANIFEST and SST file table properties");
Status status;
for (auto cfd : *versions_->GetColumnFamilySet()) {
if (!cfd->IsDropped()) {
if (!cfd->IsDropped() && status.ok()) {
auto version = cfd->current();
version->Ref();
mutex_.Unlock();
Expand Down

0 comments on commit adc3b2e

Please sign in to comment.