Repository navigation
Fix CI: Enable flow_modern_syntax in OSS test config - #5307
Closed
captbaritone wants to merge 1 commit into
Closed
captbaritone wants to merge 1 commit into
captbaritone wants to merge 1 commit into
Conversation
The "Implement feature flag to gate rollout of flow modern syntax" commit (045f228) added a flow_modern_syntax feature flag and enabled it in the Rust test fixtures, but did not add it to scripts/config.tests.json. This caused the "Compiler output check" CI job to fail because the committed generated files use modern Flow syntax (readonly, {}) while the CI compiler produces classic syntax (+, {||}).
captbaritone
force-pushed
the
fix-ci-failures-20260601
branch
from
June 1, 2026 21:01
2dfc3be to
b7ad957
Compare
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D107158647. |
Contributor
|
@captbaritone merged this pull request in caac2d4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
045f228("Implement feature flag to gate rollout of flow modern syntax")flow_modern_syntaxfeature flag and enabled it in the Rust test fixtures, but did not add it toscripts/config.tests.jsonconfig.tests.json, it produces classic Flow syntax (+for readonly,{||}for exact objects) while the committed files use modern syntax (readonly,{})"flow_modern_syntax": {"kind": "enabled"}to the feature flags inscripts/config.tests.jsonto matchTest plan