Remove enable_legacy_verbose_resolver_syntax feature flag#5170
Open
captbaritone wants to merge 2 commits intofacebook:mainfrom
Open
Remove enable_legacy_verbose_resolver_syntax feature flag#5170captbaritone wants to merge 2 commits intofacebook:mainfrom
captbaritone wants to merge 2 commits intofacebook:mainfrom
Conversation
The legacy verbose resolver syntax (@ontype, @onInterface, @Fieldname, @edgeto) has been deprecated and the flag defaults to disabled, meaning it already produces a compiler error. This removes the flag entirely and deletes all unreachable legacy code paths, constants, error types, IR types, and test fixtures (~1600 lines removed).
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D93035587. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_legacy_verbose_resolver_syntaxfeature flag and all code that becomes unreachable@onType,@onInterface,@fieldName,@edgeTo) already produces a compiler error — this makes that permanentTest plan
cargo build -p relay-docblockcompiles cleancargo build -p relay-compilercompiles cleancargo build -p relay-lspcompiles cleancargo test -p relay-docblock— all 61 tests passterse-relay-resolver-forbidden-fields.invalidtest fixture — legacy field names now rejected as "Unknown field" at the untyped representation layer