Support named exports with nodejs ESM#5162
Open
robrichard wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
9828617 to
28d1934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently not possible to use named exports with Relay in a Node.js ESM file. For example, in a brand new project with the latest version of relay-runtime as a dependency, the following code will error:
index.mjs:
When an ESM file
imports a common js file (like relay-runtime) Node.js will use cjs-module-lexer to try to determine compatible named exports.From the node.js docs:
In the entry points of react-relay and relay-runtime, the pattern of exporting a property on another object causes
cjs-module-lexerto not detect any of named exports.Example:
In this PR, I updated the entrypoints of react-relay and relay-runtime to allow Node.js's cjs named export detection to work properly. I added a test case to the Gulp build process since to test this we need the final transpiled code, but I am open to other approaches.