Add builtin scalar helpers and improve hover tooltip infrastructure#5136
Draft
captbaritone wants to merge 2 commits intofacebook:mainfrom
Draft
Add builtin scalar helpers and improve hover tooltip infrastructure#5136captbaritone wants to merge 2 commits intofacebook:mainfrom
captbaritone wants to merge 2 commits intofacebook:mainfrom
Conversation
Add 16 new test fixtures to cover previously untested hover cases: - Linked fields (direct, nested, deeply nested) - Inline fragments with type conditions - Directives (schema and Relay-specific @arguments/@argumentDefinitions) - Variable definitions (with and without defaults) - Field arguments (variables, enums, booleans, floats) - Fields that accept arguments - Fragment definition type conditions This improves test coverage for all main HoverBehavior cases in the LSP.
- Add BUILTIN_SCALAR_NAMES constant and is_builtin_scalar_name() function to schema crate for consistent builtin scalar handling - Update schema-set to use BUILTIN_SCALAR_NAMES instead of hardcoded list - Add TruncatedPrinter with print_field() and print_type_truncated() functions to schema-print crate for hover tooltip SDL generation - Add "..." truncation indicator when type definitions are truncated - Add module docblock documenting hover tooltip format conventions - Simplify Client Schema Extension hover message to always show Relay docs link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILTIN_SCALAR_NAMESconstant andis_builtin_scalar_name()function to the schema crate for consistent handling of GraphQL's built-in scalar typesBUILTIN_SCALAR_NAMESinstead of a hardcoded local arrayTruncatedPrinterwithprint_field()andprint_type_truncated()functions to schema-print crate for hover tooltip SDL generation...truncation indicator when type definitions are truncated in hover tooltipsTest plan