Skip to content

@oneOf input objects stricter typegen #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Malien wants to merge 8 commits into
base: main
Choose a base branch
from
+561 −205
Open

@oneOf input objects stricter typegen #5108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37e4468
feat: @oneOf typegen
Malien Nov 29, 2025
9cb875c
@oneOf tests
Malien Nov 30, 2025
65e5cd0
Add a config option to control @oneOf + update fixtures
Malien Nov 30, 2025
857ed69
Merge remote-tracking branch 'upstream/main' into one-of-typegen
Malien Nov 30, 2025
0b8736c
Add a comment. Update formatting
Malien Dec 6, 2025
2accada
Rename OneOfGeneration::Relaxed to Ingore
Malien Dec 6, 2025
dd09842
Revert formatting of print_schema
Malien Dec 6, 2025
6826d68
Merge remote-tracking branch 'upstream/main' into one-of-typegen
Malien Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/crates/graphql-ir/tests/parse/fixtures/argument_definitions.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ fragment TestFragment on User
alias: None,
definition: WithLocation {
location: argument_definitions.graphql:161:171,
item: FieldID(526),
item: FieldID(527),
},
arguments: [],
directives: [],
Expand Down
6 changes: 3 additions & 3 deletions compiler/crates/graphql-ir/tests/parse/fixtures/argument_with_default.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ mutation ArgumentWithDefault {
alias: None,
definition: WithLocation {
location: argument_with_default.graphql:82:90,
item: FieldID(169),
item: FieldID(170),
},
arguments: [],
directives: [],
Expand All @@ -77,7 +77,7 @@ mutation ArgumentWithDefault {
alias: None,
definition: WithLocation {
location: argument_with_default.graphql:99:103,
item: FieldID(139),
item: FieldID(140),
},
arguments: [],
directives: [],
Expand All @@ -86,7 +86,7 @@ mutation ArgumentWithDefault {
alias: None,
definition: WithLocation {
location: argument_with_default.graphql:114:118,
item: FieldID(410),
item: FieldID(411),
},
arguments: [],
directives: [],
Expand Down
2 changes: 1 addition & 1 deletion compiler/crates/graphql-ir/tests/parse/fixtures/directive-generic.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ fragment TestFragment on User {
alias: None,
definition: WithLocation {
location: directive-generic.graphql:34:36,
item: FieldID(462),
item: FieldID(463),
},
arguments: [],
directives: [
Expand Down
6 changes: 3 additions & 3 deletions compiler/crates/graphql-ir/tests/parse/fixtures/directive-include.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ fragment Foo on User {
alias: None,
definition: WithLocation {
location: directive-include.graphql:34:36,
item: FieldID(462),
item: FieldID(463),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -83,7 +83,7 @@ fragment Foo on User {
alias: None,
definition: WithLocation {
location: directive-include.graphql:97:106,
item: FieldID(459),
item: FieldID(460),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -174,7 +174,7 @@ fragment Foo on User {
alias: None,
definition: WithLocation {
location: directive-include.graphql:168:170,
item: FieldID(462),
item: FieldID(463),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions compiler/crates/graphql-ir/tests/parse/fixtures/enum-values.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ query EnumValueQuery {
alias: None,
definition: WithLocation {
location: enum-values.graphql:34:48,
item: FieldID(476),
item: FieldID(477),
},
arguments: [
Argument {
Expand All @@ -60,7 +60,7 @@ query EnumValueQuery {
alias: None,
definition: WithLocation {
location: enum-values.graphql:72:75,
item: FieldID(182),
item: FieldID(183),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions compiler/crates/graphql-ir/tests/parse/fixtures/field-arguments.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ query TestQuery {
alias: None,
definition: WithLocation {
location: field-arguments.graphql:89:107,
item: FieldID(516),
item: FieldID(517),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -144,7 +144,7 @@ query TestQuery {
alias: None,
definition: WithLocation {
location: field-arguments.graphql:164:169,
item: FieldID(56),
item: FieldID(57),
},
arguments: [],
directives: [],
Expand Down
2 changes: 1 addition & 1 deletion compiler/crates/graphql-ir/tests/parse/fixtures/fixme_fat_interface_on_union.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ query Test {
alias: None,
definition: WithLocation {
location: fixme_fat_interface_on_union.graphql:51:53,
item: FieldID(380),
item: FieldID(381),
},
arguments: [],
directives: [
Expand Down
10 changes: 5 additions & 5 deletions compiler/crates/graphql-ir/tests/parse/fixtures/fragment-with-arguments-syntax.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ fragment Foo($localId: ID!) on User {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:71:85,
item: FieldID(476),
item: FieldID(477),
},
arguments: [
Argument {
Expand Down Expand Up @@ -128,7 +128,7 @@ fragment Foo($localId: ID!) on User {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:112:115,
item: FieldID(182),
item: FieldID(183),
},
arguments: [],
directives: [],
Expand All @@ -144,7 +144,7 @@ fragment Foo($localId: ID!) on User {
),
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:138:152,
item: FieldID(476),
item: FieldID(477),
},
arguments: [
Argument {
Expand Down Expand Up @@ -180,7 +180,7 @@ fragment Foo($localId: ID!) on User {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:172:175,
item: FieldID(182),
item: FieldID(183),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -289,7 +289,7 @@ fragment Foo($localId: ID!) on User {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:246:248,
item: FieldID(462),
item: FieldID(463),
},
arguments: [],
directives: [],
Expand Down
10 changes: 5 additions & 5 deletions compiler/crates/graphql-ir/tests/parse/fixtures/fragment-with-arguments.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:131:145,
item: FieldID(476),
item: FieldID(477),
},
arguments: [
Argument {
Expand Down Expand Up @@ -141,7 +141,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:172:175,
item: FieldID(182),
item: FieldID(183),
},
arguments: [],
directives: [],
Expand All @@ -157,7 +157,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
),
definition: WithLocation {
location: fragment-with-arguments.graphql:198:212,
item: FieldID(476),
item: FieldID(477),
},
arguments: [
Argument {
Expand Down Expand Up @@ -193,7 +193,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:232:235,
item: FieldID(182),
item: FieldID(183),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -326,7 +326,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:347:349,
item: FieldID(462),
item: FieldID(463),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions compiler/crates/graphql-ir/tests/parse/fixtures/fragment-with-literal-arguments.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-arguments.graphql:174:188,
item: FieldID(476),
item: FieldID(477),
},
arguments: [
Argument {
Expand Down Expand Up @@ -180,7 +180,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-arguments.graphql:215:218,
item: FieldID(182),
item: FieldID(183),
},
arguments: [],
directives: [],
Expand Down
8 changes: 4 additions & 4 deletions ...phql-ir/tests/parse/fixtures/fragment-with-literal-enum-arguments-into-enum-list.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ fragment ChildFragment on User
),
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:53:61,
item: FieldID(453),
item: FieldID(454),
},
arguments: [
Argument {
Expand Down Expand Up @@ -66,7 +66,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:92:97,
item: FieldID(56),
item: FieldID(57),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -197,7 +197,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:253:261,
item: FieldID(453),
item: FieldID(454),
},
arguments: [
Argument {
Expand Down Expand Up @@ -237,7 +237,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:297:302,
item: FieldID(56),
item: FieldID(57),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions ...iler/crates/graphql-ir/tests/parse/fixtures/fragment-with-literal-enum-arguments.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ fragment ChildFragment on Query
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments.graphql:90:98,
item: FieldID(515),
item: FieldID(516),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -219,7 +219,7 @@ fragment ChildFragment on Query
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments.graphql:292:300,
item: FieldID(515),
item: FieldID(516),
},
arguments: [],
directives: [],
Expand Down
8 changes: 4 additions & 4 deletions ...crates/graphql-ir/tests/parse/fixtures/fragment-with-literal-enum-list-arguments.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ fragment ChildFragment on User
),
definition: WithLocation {
location: fragment-with-literal-enum-list-arguments.graphql:53:61,
item: FieldID(453),
item: FieldID(454),
},
arguments: [
Argument {
Expand Down Expand Up @@ -66,7 +66,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-list-arguments.graphql:92:97,
item: FieldID(56),
item: FieldID(57),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -201,7 +201,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-list-arguments.graphql:255:263,
item: FieldID(453),
item: FieldID(454),
},
arguments: [
Argument {
Expand Down Expand Up @@ -241,7 +241,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-list-arguments.graphql:299:304,
item: FieldID(56),
item: FieldID(57),
},
arguments: [],
directives: [],
Expand Down
10 changes: 5 additions & 5 deletions ...er/crates/graphql-ir/tests/parse/fixtures/fragment-with-literal-object-arguments.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ fragment ChildFragment on Query
alias: None,
definition: WithLocation {
location: fragment-with-literal-object-arguments.graphql:105:110,
item: FieldID(56),
item: FieldID(57),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -142,7 +142,7 @@ fragment ChildFragment on Query
},
type_: NonNull(
Named(
InputObject(17),
InputObject(18),
),
),
default_value: None,
Expand Down Expand Up @@ -188,7 +188,7 @@ fragment ChildFragment on Query
},
type_: NonNull(
Named(
InputObject(17),
InputObject(18),
),
),
default_value: None,
Expand Down Expand Up @@ -236,7 +236,7 @@ fragment ChildFragment on Query
),
},
type_: Named(
InputObject(17),
InputObject(18),
),
},
),
Expand All @@ -249,7 +249,7 @@ fragment ChildFragment on Query
alias: None,
definition: WithLocation {
location: fragment-with-literal-object-arguments.graphql:308:313,
item: FieldID(56),
item: FieldID(57),
},
arguments: [],
directives: [],
Expand Down
Loading