Fix render and dispose checks in useQueryLoader tests #4737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.internalfb.com/diff/D22752821?transaction_fbid=285140592587921&whitespace=SHOW_ALL, tests on `renderCount` would be testing React internals, which is unadvised since the tests may fail depending on the React version, and are probably ok to remove. But, these tests are testing Relay behavior -- whether queries are disposed upon re-render -- so I kept the React `renderCount` checks to clarify the expected render behavior that is triggering these query disposals. I updated the `renderCount` to the correct number for React 19.
|
@monicatang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on
renderCountwould be testing React internals, which is unadvised since the tests may fail depending on the React version, and are probably ok to remove. But, these tests are testing Relay behavior -- whether queries are disposed upon re-render -- so I kept the ReactrenderCountchecks to clarify the expected render behavior that is triggering these query disposals.I updated the
renderCountto the correct number for React 19.