[relay-compiler] Export node from assignable fragment#4409
Closed
tobias-tengler wants to merge 4 commits intofacebook:mainfrom
Closed
[relay-compiler] Export node from assignable fragment#4409tobias-tengler wants to merge 4 commits intofacebook:mainfrom
tobias-tengler wants to merge 4 commits intofacebook:mainfrom
Conversation
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@captbaritone I think I'm not supposed to check in the cargo.lock file, but it needs to be updated for the tests to run. Should I create a separate PR to update the lockfile? |
Contributor
|
Fix is here (I just imported it): #4402 you can ignore those test failures, they'll run correctly internally |
Contributor
Author
|
@captbaritone I updated all my PRs with the recently merged Cargo.lock update and all the tests are passing again 🎉 🤞we can get this PR and the others merged soon: |
Contributor
|
@captbaritone merged this pull request in 1328fc1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #4370