Repro for queryCacheExpirationTime not working in hooks #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsavona
force-pushed
the
query-cache-expiration-time-repro
branch
from
b7974f5
to
1f3ea7b
Compare
|
@josephsavona has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro for
queryCacheExpirationTimenot working in Relay Hooks (or at least not in useLazyLoadQuery). It appears that fetchQueryInternal's deduped entry isn't cleared even after the previous instance of the hook is unmounted, and the subsequent hook invocation reuses this fetch entry. Ie, the runtime correctly detects the query as stale and tries to refetch, but our network caching says no and reuses the previous query.