[meta] Make all state contextual #558

josephsavona · 2015-11-07T20:11:33Z

josephsavona · 2015-11-07T20:11:38Z

cc @devknoll who's started experimenting with this in #557

devknoll · 2015-11-08T21:14:53Z

Optionally, Relay.injectTaskScheduler and Relay.injectNetworkLayer could be moved to the Relay Context class to allow different schedulers/network layers per context.

I think this is actually fairly critical for server side rendering.

devknoll · 2015-11-08T21:23:21Z

@josephsavona Do we want RelayStore to own the RelayStoreData instances? Seems like yes, but wanted to confirm.

devknoll · 2015-11-08T21:32:17Z

@josephsavona Also GraphQLStoreRangeUtils seems a little tough. Not sure who should own the instance in this case. Going to try keeping it in RelayStoreData and passing it down.

josephsavona · 2015-11-08T21:51:47Z

The methods for injecting these should be on Relay.Store since that's public, but they should save the scheduler/network layer to RelayStoreData.

josephsavona · 2015-11-08T21:52:56Z

Re RangeUtils, agree this map can be saved into StoreData.

devknoll · 2015-11-08T22:37:58Z

Looks like GraphQLStoreChangeEmitter depends on GraphQLStoreRangeUtils too. How should we approach that?

josephsavona · 2015-11-08T22:47:47Z

I was on my phone earlier, so here's more context on each of the above

GraphQLStoreChangeEmitter also needs to be contextualized. It doesn't need to depend on GraphQLStoreRangeUtils - instead, RelayStoreData could be changed to call changeEmitter.broadcastChangeForID with an ID that is already in canonical form. RelayStoreData will own the range utils so this should be okay.

Re the distinction between RelayStore and RelayStoreData - in the interim, it's probably best to put all public methods on RelayStore, while holding and modifying all state in RelayStoreData.

devknoll · 2015-11-08T22:55:56Z

Super helpful, thanks 👍

Summary: Contextualize `RelayMutationTransaction` and update call sites. Original Summary: Builds on #561. Part of #558 Closes #562 Reviewed By: yungsters Differential Revision: D2632150 fb-gh-sync-id: 5e40ce6d3a3dea5bd10f131aec43d1950877c62b

Summary: Converts `ChangeEmitter` to a class instead of singleton and holds an instance in `RelayStoreData`. Note that `QueryResolver` was already contextualized (it accepts an instance of `RelayRecordStore`) but it now needs the `RelayStoreData` instance to get access to the change emitter. Original:Builds on #562. Part of #558 Closes #565 Reviewed By: yungsters Differential Revision: D2632148 fb-gh-sync-id: b5073151d6459c018bc56654a9deb8bb407fcc41

vslinko · 2016-01-10T10:23:13Z

@josephsavona you can use this syntax to track subtasks:

* [ ] In progress
* [x] Done

Result:

In progress
Done

Summary: > This PR is another step toward making all Relay state contextual (#558). Originally this was submitted as a part of #683, but josephsavona [suggested](#683 (comment)) to split it to smaller PRs. `RelayContext` will ultimately be the public API of Relay Core, exposing all methods required to implement declarative APIs such as `RelayRootContainer` and `RelayContainer`, and will manage its own private instance of `RelayStoreData` (which will be an implementation detail). This diff is a first step in that direction: - Creates the `RelayContext` class - Changes `RelayStore` to be a (singleton) instance of the above, using the singleton `RelayStoreData` to ensure that callers of `RelayStoreData.getDefaultInstance()` get access to the same information as that accessed by via `RelayStore` - i.e., that all existing apps keep working as-is. Closes #698 Reviewed By: yungsters Differential Revision: D2784307 fb-gh-sync-id: e1764f9e0ef1dc7a1d1016fe8fdfd9012e7e63d3

Summary: This PR is another step toward making all Relay state contextual (#558). Originally this was submitted as a part of #683, but josephsavona [suggested](#683 (comment)) to split it to smaller PRs. Closes #761 Reviewed By: wincent Differential Revision: D2863416 fb-gh-sync-id: f9907959aac71b14e54d2746b86927b6fd8b1952

leebenson · 2016-03-03T15:07:39Z

is there a timeline for release? I'd love to contribute, but finding the time to get up to speed with the internals would probably be longer than it'd take you to finish.

josephsavona · 2016-03-03T15:35:35Z

Just a heads up that this and the react-relay/Relay core split will be my main area of focus for the next couple months. Contributions are welcome, but definitely reach out to us before starting a major PR in this area.

josephsavona · 2016-03-03T15:37:09Z

@leebensen there are always things that need attention. I'd recommend starting with a small task at first - take a look at issues tagged with "good first bug"!

Summary:== Original Description == This PR is another step toward making all Relay state contextual (#558). Contextual `RelayNetworkLayer` is important for server-side rendering. It will allow to inject a contextual network layer initialized with client request specific params (e.g. authentication cookies) on the server. Currently it is impossible because the injected network layer is global, and shared between client requests. == Summary of Changes == - Moves `fetchRelayQuery` to a method on `RelayNetworkLayer`, which is now a class with an instance held by each `RelayStoreData`, thereby making the network layer contextual to the context instance. - Changes `Relay.injectNetworkLayer` to a facade for `RelayStore.injectNetworkLayer()`. - Changes the FB/OSS `Relay` module to inject a network layer directly on `RelayStore`. - Re-create `fetchRelayQuery` in relay-fb for convenience Closes #704 Reviewed By: wincent Differential Revision: D3016293 Pulled By: josephsavona fb-gh-sync-id: 2e5f3163bc048a089776477b3d2dac2546fd9f48 shipit-source-id: 2e5f3163bc048a089776477b3d2dac2546fd9f48

Summary:== Original Description == This PR is another step toward making all Relay state contextual (#558). Originally this was submitted as a part of #683, but josephsavona [suggested](#683 (comment)) to split it to smaller PRs. == Summary of Changes == - Make `relayContext` a required prop on `RelayRenderer` - Change `RelayRootContainer` to pass `RelayStore` (a default instance of RelayContext) as the relayContext prop to its internal RelayRenderer - Update tests (in particular, checking that changing the relayContext prop on RelayRenderer works as expected) - Update products that use RelayRenderer directly to pass RelayStore as the Relay context Closes #810 Reviewed By: wincent Differential Revision: D3006237 Pulled By: josephsavona fb-gh-sync-id: 6cf774f1ee5a81ec9d3c5e499f0d1e25fe3befc5 shipit-source-id: 6cf774f1ee5a81ec9d3c5e499f0d1e25fe3befc5

Reviewed By: wincent Differential Revision: D3017230 fb-gh-sync-id: 0de370b24e0db51b3dbbce4a55f6eb8167390773 shipit-source-id: 0de370b24e0db51b3dbbce4a55f6eb8167390773

josephsavona · 2016-03-07T16:58:50Z

Heads up that we're renaming RelayContext to RelayEnvironment. It's common in Relay apps to render multiple RelayRootContainers (e.g. one for each tab in a TabView), and RelayContext suggests an incorrect association with React contexts which are one-per-root component.

Summary:== Original Description == This PR is another step toward making all Relay state contextual (#558). Originally this was submitted as a part of #683, but josephsavona [suggested](#683 (comment)) to split it to smaller PRs. Currently, Relay resolve mutations props using the global `RelayStore`, and store them in the `props` instance field of `RelayMutation`. That makes it impossible to contextualize Relay mutations without changing the public API. After analyzing different alternatives, I have found that the probably cleanest solution is not to store resolved mutation props in an instance field, but to pass them as an argument to each of the mutation methods. That way mutations can be reused in different `RelayStoreData` contexts, and also they can be reused in the same context but at different times, because props are re-resolved at each mutation execution. == Summary of Changes == - Change `RelayMutation` constructor to not immediately resolve data for fragment props - Add `bindContext` method on RelayMutation, called when the mutation is committed on a specific RelayContext - This necessitated adding the `read` method to `RelayContextInterface`, and stubbing this method on alternative context implementations. - Updated mutation docs to mention this method. Closes #699 Reviewed By: yungsters Differential Revision: D2913334 Pulled By: josephsavona fb-gh-sync-id: 5051fddf068fc8bc7379bb55c8b1e4d97e33313c shipit-source-id: 5051fddf068fc8bc7379bb55c8b1e4d97e33313c

josephsavona · 2016-03-09T13:45:15Z

As of 8e53183, all of Relay's internal state tracking has been contextualized. Each instance of RelayEnvironment is an isolated environment with its own cache of data, network layer, task scheduler, etc. This is an important prerequisite for server rendering in open source as well as allowing some new use cases. The next step is #559 - splitting Relay Core and the React/Relay integration layer - follow along there for more details.

Thanks especially to @denvned and @devknoll for their impressive contributions!

schickling · 2016-03-09T14:27:05Z

Awesome. Looking forward to it! 🎉

rodrigopr · 2016-03-09T14:59:26Z

Amazing work! Thanks @denvned, @devknoll, @josephsavona . 🎉

KyleAMathews · 2016-03-09T17:02:39Z

Yeah!

On Wed, Mar 9, 2016 at 6:59 AM Rodrigo Ribeiro notifications@github.com
wrote:

Amazing work! Thanks @denvned https://github.com/denvned, @devknoll
https://github.com/devknoll, @josephsavona
https://github.com/josephsavona . [image: 🎉]

—
Reply to this email directly or view it on GitHub
#558 (comment).

koistya · 2016-03-12T12:38:20Z

Great news. Big thanks to all the contributors!

This was referenced Nov 8, 2015

Make GraphQLQueryRunner contextual #560

Closed

Make GraphQLDeferredQueryTracker contextual #561

Closed

Make RelayMutationTransaction contextual #562

Closed

This was referenced Nov 13, 2015

Implement RelayStore.reset() #233

Closed

Make RelayRenderer isomorphic #589

Closed

This was referenced Nov 14, 2015

Error: No result for query "$$_route[1]_question" denvned/isomorphic-relay-router#4

Closed

How can i pass credentials (cookies) to networkLayer ? denvned/isomorphic-relay#1

Closed

josephsavona mentioned this issue Dec 21, 2015

Add Relay context to Relay containers #683

Closed

This was referenced Dec 22, 2015

Add RelayContext #698

Closed

Contextualize Relay mutations #699

Closed

Contextualize RelayNetworkLayer #704

Closed

josephsavona mentioned this issue Jan 5, 2016

Using Relay without React #721

Closed

josephsavona mentioned this issue Jan 10, 2016

Provide hooks for server-side rendering #136

Closed

denvned mentioned this issue Jan 22, 2016

Contextualize RelayContainer #761

Closed

josephsavona mentioned this issue Feb 3, 2016

Update roadmap for H1 2016 #788

Closed

denvned mentioned this issue Feb 9, 2016

Contextualize RelayRenderer #810

Closed

josephsavona mentioned this issue Feb 11, 2016

Idea: Simplify and encapsulate mutation calls? #824

Closed

josephsavona added the enhancement label Feb 16, 2016

josephsavona mentioned this issue Feb 20, 2016

Deprecate Relay.RootContainer in favor of <RelayRenderer> #528

Closed

4 tasks

rattrayalex mentioned this issue Feb 29, 2016

Support server-side rendering relay-tools/react-router-relay#69

Closed

This was referenced Mar 3, 2016

Reset store functionality #898

Closed

forceFetch without using node (without id) #858

Closed

josephsavona referenced this issue Mar 7, 2016

Contextualize RelayTaskScheduler

e68e4a6

Reviewed By: wincent Differential Revision: D3017230 fb-gh-sync-id: 0de370b24e0db51b3dbbce4a55f6eb8167390773 shipit-source-id: 0de370b24e0db51b3dbbce4a55f6eb8167390773

josephsavona self-assigned this Mar 7, 2016

josephsavona mentioned this issue Mar 7, 2016

Websockets and Relay #51

Closed

josephsavona closed this as completed Mar 9, 2016

tlvenn mentioned this issue Apr 7, 2016

Add RelayEnvironment to the public API #1025

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[meta] Make all state contextual #558

[meta] Make all state contextual #558

josephsavona commented Nov 7, 2015

josephsavona commented Nov 7, 2015

devknoll commented Nov 8, 2015

devknoll commented Nov 8, 2015

devknoll commented Nov 8, 2015

josephsavona commented Nov 8, 2015

josephsavona commented Nov 8, 2015

devknoll commented Nov 8, 2015

josephsavona commented Nov 8, 2015

devknoll commented Nov 8, 2015

vslinko commented Jan 10, 2016

leebenson commented Mar 3, 2016

josephsavona commented Mar 3, 2016

josephsavona commented Mar 3, 2016

josephsavona commented Mar 7, 2016

josephsavona commented Mar 9, 2016

schickling commented Mar 9, 2016

rodrigopr commented Mar 9, 2016

KyleAMathews commented Mar 9, 2016

koistya commented Mar 12, 2016

[meta] Make all state contextual #558

[meta] Make all state contextual #558

Comments

josephsavona commented Nov 7, 2015

josephsavona commented Nov 7, 2015

devknoll commented Nov 8, 2015

devknoll commented Nov 8, 2015

devknoll commented Nov 8, 2015

josephsavona commented Nov 8, 2015

josephsavona commented Nov 8, 2015

devknoll commented Nov 8, 2015

josephsavona commented Nov 8, 2015

devknoll commented Nov 8, 2015

vslinko commented Jan 10, 2016

leebenson commented Mar 3, 2016

josephsavona commented Mar 3, 2016

josephsavona commented Mar 3, 2016

josephsavona commented Mar 7, 2016

josephsavona commented Mar 9, 2016

schickling commented Mar 9, 2016

rodrigopr commented Mar 9, 2016

KyleAMathews commented Mar 9, 2016

koistya commented Mar 12, 2016