Update print warning script for low priority warning#9756
Merged
flarnie merged 2 commits intofacebook:masterfrom May 26, 2017
Merged
Update print warning script for low priority warning#9756flarnie merged 2 commits intofacebook:masterfrom
flarnie merged 2 commits intofacebook:masterfrom
Conversation
This was referenced May 23, 2017
Closed
**what is the change?:** This change makes 'lowPriorityWarning' an exact copy of 'warning.js' from https://github.com/facebook/fbjs/blob/e66ba20ad5be433eb54423f2b097d829324d9de6/packages/fbjs/src/__forks__/warning.js where before we had skipped some checks from that module. - Adds an error which we catch, in order to let people find the error and resulting stack trace when using devtools with 'pause on caught errors' checked. - Adds check that 'format' argument is passed **why make this change?:** - To maintain a closer fork to 'warning.js' - To allow easier debugging using 'pause on caught errors' - To validate inputs to 'lowPriorityWarning' **test plan:** `yarn test` **issue:**
**what is the change?:** We print the logs from 'lowPriorityWarning' as well as 'warning' from the 'print-warnings' script. NOTE: This PR is branching off of facebook#9754 **why make this change?:** We want to use the same process of white/blacklisting warnings with 'lowPriorityWarning' that we do with 'warning'. **test plan:** This is not super easy to test unless we are doing a sync with FB afaik. I plan on running a sync in the next few days, or next week at latest, for the sake of not landing big things on a Friday. That will be the actual test of this. **issue:** facebook#9398
flarnie
force-pushed
the
updatePrintWarningScriptForLowPriorityWarning
branch
from
a2eca37 to
9e54672
Compare
Contributor
Author
|
boop |
sophiebits
approved these changes
May 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR was made on a branch that goes off of #9754 and I'll rebase it once that lands.
So when reviewing just look at the change in
scripts/print-warnings/print-warnings.js.