Fix references to the old ReactID syntax #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // No ID on `childNodeA`, it was "rendered by the browser". | ||
| ReactMount.setID(childNodeB, '.react[0].1:0'); | ||
| ReactMount.setID(childNodeB, '.0.1:0'); |
There was a problem hiding this comment.
So are these tests not actually testing anything?
There was a problem hiding this comment.
@zpao Work computer bugged out so I can't access it from home, they're OK I think, it's just that the ID they set is (basically) irrelevant.
zpao
added a commit
that referenced
this pull request
Jan 31, 2014
Fix references to the old ReactID syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No one must find out :)
Thanks for @plievone for pointing it out, #934