Skip to content

Adds a dummy function to assist react devtools to look for minification #9661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+19 −1
Closed

Adds a dummy function to assist react devtools to look for minification #9661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ae60df
Adds `testMinification` to assist react devtools to look for minifica…
ManasJayanth Jun 30, 2017
70aa887
Adds a warning for minified development build
ManasJayanth Jun 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/renderers/shared/fiber/ReactFiberDevToolsHook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,24 @@ let rendererID = null;
let injectInternals = null;
let onCommitRoot = null;
let onCommitUnmount = null;

// A dummy function to check for minification during runtime
// Refer https://github.com/facebook/react-devtools/issues/694#issuecomment-300535376
var testMinification = function testMinification() {
if (__DEV__) {
return 42;
}
};

warning(
(testMinification.name || testMinification.toString())
.indexOf('testMinification') !== -1,
"It looks like you're using a minified copy of the development build " +
'of React. When deploying React apps to production, make sure to use ' +
'the production build which skips development warnings and is faster. ' +
'See https://fb.me/react-minification for more details.',
);

if (
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ !== 'undefined' &&
__REACT_DEVTOOLS_GLOBAL_HOOK__.supportsFiber
Expand All @@ -35,7 +53,7 @@ if (

injectInternals = function(internals: Object) {
warning(rendererID == null, 'Cannot inject into DevTools twice.');
rendererID = inject(internals);
rendererID = inject(Object.assign({}, internals, {testMinification}));
};

onCommitRoot = function(root: FiberRoot) {
Expand Down