Improve docs for select multiple #9539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview failed. Built with commit 1f0f0cf https://app.netlify.com/sites/reactjs/deploys/59d1776ddf99535070fb1d58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1700
Currently it only re-adds the original note.
However, I'd like to discuss adding a new section, maybe called "Selecting Multiple Values", with a full example similar to the current
<select>flavor example. This example would instead involve selecting multiple values by appending or removing values from the array in thevalueproperty of the<select>tag when the user clicks an<option>tag. Would this be preferable to the single block-quote style note from the old docs?