Consolidate events between EventConstants and BrowserEventEmitter#9512
Consolidate events between EventConstants and BrowserEventEmitter#9512sophiebits merged 3 commits intofacebook:masterfrom
Conversation
sophiebits
left a comment
sophiebits
left a comment
There was a problem hiding this comment.
lgtm, just a couple inline notes. Happy to merge after you fix them.
| } | ||
|
|
||
| /** | ||
| * @param {string} topLevelType Record from `EventConstants`. |
There was a problem hiding this comment.
can you revert this file?
|
|
||
| var getVendorPrefixedEventName = require('getVendorPrefixedEventName'); | ||
|
|
||
| export type PropagationPhases = 'bubbled' | 'captured'; |
There was a problem hiding this comment.
Rollover from EventConstants. Happy to remove though.
There was a problem hiding this comment.
Ah right, it gets referenced here: https://github.com/facebook/react/pull/9512/files#diff-1ca53ffa4da75a64f7c3b2f131f62da7R21
There was a problem hiding this comment.
Let's just move it to that file.
nhunzaker
force-pushed
the
consolidate-events
branch
from
eef542a to
1c00c12
Compare
|
I think everything should be good to go. Struggling with CI however. Any ideas? |
Does moving the file to src/renderers/dom/shared/event/BrowserEventConstants.js fix the issue? That is where it should be anyway. |
This is a follow up to facebook#9333. This commit removes some duplication of event names and renames the EventConstants module to BrowserEventConstants.
Fixes an issue during build.
nhunzaker
force-pushed
the
consolidate-events
branch
from
b8c7a63 to
31e8988
Compare
|
@spicyj Hey, that did it! I just upstreamed from master, but looks like that was it! |
|
Thanks! |
3 participants
This is a follow up to the request made by @spicyj in #9333. This commit removes some duplication of event names by consolidating them into the EventConstants module. It then renames that module to BrowserEventConstants.