Update example snippet in old 'React.addons' doc page #9363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the example more consistent.
sophiebits
approved these changes
Apr 7, 2017
bvaughn
approved these changes
Apr 7, 2017
In facebook#9359 we accidentally removed pointers in some doc pages. Putting them back now.
This seems like a more stable place to link to in the 'context' document. Based on @bvaughn's feedback in facebook#9359
|
Just added a couple other minor changes based on comments on #9359 |
|
Thanks! |
gaearon
approved these changes
Apr 7, 2017
acdlite
pushed a commit
that referenced
this pull request
Apr 7, 2017
* Update example snippet in old 'React.addons' doc page This makes the example more consistent. * Add back the pointers in docs that were mistakenly removed In #9359 we accidentally removed pointers in some doc pages. Putting them back now. * Link to npm package instead of github page This seems like a more stable place to link to in the 'context' document. Based on @bvaughn's feedback in #9359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made an improvement based on feedback from @gaearon on #9359
If we have any other minor changes that get flagged they can be made on this branch.