Skip to content

Conversation

@edvinerikson
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Run the Flow typechecks (npm run flow).
  7. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  8. If you haven't already, complete the CLA.

@gaearon
Copy link
Collaborator

gaearon commented Jan 24, 2017

Now that I think of it why do we ever return null now? Let's change it to always fall back to "Component".

@gaearon gaearon self-assigned this Jan 24, 2017
@edvinerikson
Copy link
Contributor Author

Not sure what circleci is up to but I ran the tests and flow locally without any errors

@gaearon
Copy link
Collaborator

gaearon commented Jan 24, 2017

k

@gaearon gaearon merged commit 5170db8 into facebook:master Jan 24, 2017
@edvinerikson edvinerikson deleted the patch-1 branch January 24, 2017 18:32
@sophiebits
Copy link
Collaborator

You don't think Unknown is nicer? We use that as a fallback for the stack, for instance.

@gaearon
Copy link
Collaborator

gaearon commented Jan 24, 2017

That probably broke the CI :P.
I agree, let's change to "Unknown".

@edvinerikson
Copy link
Contributor Author

should I send a PR?

@gaearon
Copy link
Collaborator

gaearon commented Jan 25, 2017

Please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants