Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rendering-elements.md #8704

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Update rendering-elements.md #8704

merged 1 commit into from
Jan 6, 2017

Conversation

murtazahaveliwala
Copy link
Contributor

Updating text to be in sync with sample html

@murtazahaveliwala
Update rendering-elements.md
97701ad 
Updating text to be in sync with sample html
@bvaughn
Copy link
Contributor

bvaughn commented Jan 6, 2017

Thanks 😄

@bvaughn bvaughn merged commit 933805b into facebook:master Jan 6, 2017
@murtazahaveliwala murtazahaveliwala deleted the patch-3 branch January 6, 2017 18:28
@gaearon
Copy link
Collaborator

gaearon commented Jan 6, 2017

@bvaughn Please "Squash and Merge" documentation PRs. The tool doesn't understand merge commits :-(. cc @zpao

@bvaughn
Copy link
Contributor

bvaughn commented Jan 6, 2017

Guh! Sorry @gaearon. I thought that only applied to multi-commit PRs.

@gaearon
Copy link
Collaborator

gaearon commented Jan 6, 2017

You can also fix the tool to understand them. AFAIK it would just need to pass -m 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murtazahaveliwala @bvaughn @gaearon @facebook-github-bot