update to codebase-overview.md #8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bonham000. The edits look good. 😄 |
|
@bvaughn Please tag any merged doc PRs with "Documentation: needs merge to stable". Otherwise we won't cherry-pick them to |
gaearon
added
Documentation: needs merge to stable
and removed
Documentation: needs merge to stable
labels
gaearon
pushed a commit
that referenced
this pull request
Jan 4, 2017
update to codebase-overview.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR to the React codebase, I think I have followed all the directions correctly but please let me know if I need to do anything differently. I've suggested three grammatical changes to the codebase-overview document. Thank you!