-
Notifications
You must be signed in to change notification settings - Fork 47.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed webpack's hyperlink #8650
Conversation
..to point to 2.x documentation instead of 1.x (and to be consistent with other links on the page)
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It's not stable yet, and Webpack repo points to 1.x docs. Why make the change? |
@gaearon you linked to webpack.js.org twice in db140c8 (one, two) when you added the links, I assumed that was intentional? I can change them all to the |
ping @gaearon, did you want me to change all the links to point to |
Looks like I linked inconsistently, even db140c8 includes both style of links. I'd say let's change them all to point to 1.x, wanna do it? |
You bet I do! |
..to point to 2.x documentation instead of 1.x (and to be consistent with other links on the page)
..to point to 2.x documentation instead of 1.x (and to be consistent with other links on the page)
Before submitting a pull request, please make sure the following is done...
master
.npm test
).npm run lint
) - we've done our best to make sure these rules match our internal linting guidelines.