Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed webpack's hyperlink #8650

Merged
merged 1 commit into from
Dec 28, 2016
Merged

Changed webpack's hyperlink #8650

merged 1 commit into from
Dec 28, 2016

Conversation

gitanupam
Copy link
Contributor

..to point to 2.x documentation instead of 1.x (and to be consistent with other links on the page)

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

..to point to 2.x documentation instead of 1.x (and to be consistent with other links on the page)
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gaearon
Copy link
Collaborator

gaearon commented Dec 28, 2016

It's not stable yet, and Webpack repo points to 1.x docs. Why make the change?

@aweary
Copy link
Contributor

aweary commented Dec 28, 2016

@gaearon you linked to webpack.js.org twice in db140c8 (one, two) when you added the links, I assumed that was intentional? I can change them all to the 1.x docs if it wasn't.

@aweary
Copy link
Contributor

aweary commented Jan 3, 2017

ping @gaearon, did you want me to change all the links to point to 1.x docs instead?

@gaearon
Copy link
Collaborator

gaearon commented Jan 3, 2017

Looks like I linked inconsistently, even db140c8 includes both style of links. I'd say let's change them all to point to 1.x, wanna do it?

@aweary
Copy link
Contributor

aweary commented Jan 3, 2017

You bet I do!

@aweary aweary self-assigned this Jan 3, 2017
gaearon pushed a commit that referenced this pull request Jan 4, 2017
..to point to 2.x documentation instead of 1.x (and to be consistent with other links on the page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants