Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed InitializeJavaScriptAppEngine to InitializeCore #8558

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Renamed InitializeJavaScriptAppEngine to InitializeCore #8558

merged 2 commits into from
Dec 13, 2016

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Dec 12, 2016

Prerequisite for the new ReactNativeFiber renderer.

sophiebits
sophiebits approved these changes Dec 12, 2016
View reviewed changes
Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, thanks

edvinerikson
edvinerikson reviewed Dec 12, 2016
View reviewed changes
Copy link
Contributor

@edvinerikson edvinerikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is a mock for this file as well

@sophiebits
Copy link
Collaborator

(y) good catch @edvinerikson

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 12, 2016

👍 Thanks

@bvaughn bvaughn mentioned this pull request Dec 12, 2016
Merged
@bvaughn bvaughn merged commit 369769a into facebook:master Dec 13, 2016
@bvaughn bvaughn deleted the rename-initialize-core branch December 13, 2016 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvinerikson edvinerikson edvinerikson left review comments

@sophiebits sophiebits sophiebits approved these changes

Assignees

@sophiebits sophiebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvaughn @sophiebits @edvinerikson @facebook-github-bot