Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rootContainerInstance param to createTextInstance #8557

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Dec 12, 2016

This mirrors a recent change (c87ffc0) in params passed to createChild and cleans up a root container hack currently required for the native fiber renderer to create text views.

This mirrors a recent change in params passed to  and cleans up a HACK currently required for the native fiber renderer to create text views.
Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bvaughn bvaughn merged commit 0a3256a into facebook:master Dec 12, 2016
@bvaughn bvaughn deleted the add-create-text-instance-param branch December 12, 2016 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants