[Fiber]Fix tests for mount/update callback errors #8436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koba04
changed the title
koba04
force-pushed
the
fix-fiber-tests-for-update-callback
branch
from
64ad409
to
f141f18
Compare
|
I don't think we'll want to pay the runtime cost and extra library size only for this error message. |
koba04
changed the title
|
@sebmarkbage |
|
This has been fixed by #8677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some failing Fiber tests.
This is passing
callerNameto validate callback arguments.callerNameis being passed as an optional argument. Should I annotate it as a required argument?