Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide detailed failure output in scripts/fiber/record-tests #8214

Merged
merged 1 commit into from
Nov 7, 2016
Merged

Hide detailed failure output in scripts/fiber/record-tests #8214

merged 1 commit into from
Nov 7, 2016

Conversation

sophiebits
Copy link
Collaborator

image

@cpojer
Copy link
Contributor

cpojer commented Nov 6, 2016

I think this is fine but I feel like adding a flag for this in Jest (opposite of --verbose) would have been simpler than this :D

@sophiebits
Copy link
Collaborator Author

sophiebits commented Nov 7, 2016 •
edited
Loading

Thanks. I was actually in the middle of writing a test runner wrapper for another reason (to hackily split out "passing" from "passing except dev warnings" from "failing") and once I got here I realized that it was just one line (.failureMessage = null) to get this to work.

@sophiebits sophiebits mentioned this pull request Nov 7, 2016
Merged
@sophiebits sophiebits merged commit c4b9330 into facebook:master Nov 7, 2016
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
@sophiebits @acusti
Hide detailed failure output in scripts/fiber/record-tests (facebook#…
78f8cf5 
…8214)

![image](https://cloud.githubusercontent.com/assets/6820/20033841/a55fefa4-a367-11e6-99c0-44dfe38e1db7.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpojer cpojer

@gaearon gaearon

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophiebits @cpojer @gaearon @facebook-github-bot