Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Add top level render callbacks into ReactDOMFiber and ReactNoop #8102

Merged
merged 4 commits into from
Oct 26, 2016
Merged

[Fiber] Add top level render callbacks into ReactDOMFiber and ReactNoop #8102

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
465047a
[Fiber] Add top level render callbacks into ReactDOMFiber and ReactNoop
koba04 Oct 26, 2016
3f50ce6
[Fiber] Support multiple render callbacks
koba04 Oct 26, 2016
8581a92
[Fiber] `this` in render callbacks are public instances
koba04 Oct 26, 2016
b377c79
[Fiber] commitLifeCycles move to behind the effectTag check
koba04 Oct 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Fiber] commitLifeCycles move to behind the effectTag check
  • Loading branch information
@koba04
koba04 committed Oct 26, 2016
commit b377c79b6767dca4f29076481a63cc6ead077424
4 changes: 0 additions & 4 deletions src/renderers/shared/fiber/ReactFiberScheduler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,6 @@ module.exports = function<T, P, I, TI, C>(config : HostConfig<T, P, I, TI, C>) {
if (finishedWork.effectTag !== NoEffect) {
const current = finishedWork.alternate;
commitWork(current, finishedWork);
}
// if the root is a HostContainer, it may have a callback.
if (finishedWork.tag === HostContainer) {
const current = finishedWork.alternate;
commitLifeCycles(current, finishedWork);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to move in behind the effectTag check. Because we don't want to invoke this unless the root updates. This can happen if a render is scheduled, but we do a deep setState update at a higher priority first.

This isn't actually possible right now without #7457 but it will be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it to behind the effectTag check.

}
}
Expand Down