Strip PropTypes checkers in production build #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e75e8dc.
gaearon
force-pushed
the
strip-prop-types
branch
from
9da2fd0
to
be71f76
Compare
|
Looks good |
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Jan 31, 2017
…k#7132)"" This reverts commit be71f76. In other words, now we again have the warning if you attempt to call PropTypes manually. It was removed in facebook#8066 but we shouldn't have done this since we still want to avoid people accidentally calling them in production (and even more so since now it would throw). Fixes facebook#8080.
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Feb 7, 2017
…k#7132)"" This reverts commit be71f76. In other words, now we again have the warning if you attempt to call PropTypes manually. It was removed in facebook#8066 but we shouldn't have done this since we still want to avoid people accidentally calling them in production (and even more so since now it would throw). Fixes facebook#8080.
gaearon
added a commit
that referenced
this pull request
Feb 8, 2017
* Revert "Revert "Warn if PropType function is called manually (#7132)"" This reverts commit be71f76. In other words, now we again have the warning if you attempt to call PropTypes manually. It was removed in #8066 but we shouldn't have done this since we still want to avoid people accidentally calling them in production (and even more so since now it would throw). Fixes #8080. * Pass secret in ReactControlledValuePropTypes * Record tests
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
* Strip PropTypes in production build * Revert "Warn if PropType function is called manually (facebook#7132)" This reverts commit e75e8dc.
Closed
|
FWIW, this broke our code in production, but not locally as we had some code that compared propTypes to determine behaviour (ie. There is a distinct lack of documentation about the behaviour of prop-types in production, changing them from a distinct symbol to something that is equal for all types is fairly problematic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting #7651 because I accidentally nuked my fork.
Feedback from #7651 is addressed.
This removes the warning about PropTypes and actually replaces them with a single PropType function that throws in production.
Difference from master: